Both and long and short term investments can be profitable, it mainly depends on what you are after. There are persons who prefer short term investments and there are does who would go for long term.
When it comes to long-term investments, you may not be able to liquidate your assets quite easily. This is also one of the main disadvantages of long-term investments you may need to consider in the first place.